RFR: 234: Allow more granular jcheck reviewer configuration

[Robin Westberg]

On Mon, 20 Jan 2020 14:46:59 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that allows for more granular reviewers configuration
> with jcheck. With this patch a project can now specify exactly how many
> reviewers are need for each role, for example:
> 
> [checks "reviewer"]
> reviewer = 1
> committer = 1
> author = 1
> 
> The above configuration would require three reviewers in total, out of which one
> must be reviewer, one must be committer and one must be author. This granularity
> of configuration is needed to fully implement [PR 364](https://git.openjdk.java.net/skara/pulls/364).
> 
> I made sure that the patch is backwards compatible, we still support the old
> configuration syntax:
> 
> [checks "reviewer"]
> minimum = 1
> role = reviewer
> 
> The above will simply be translated to the following configuration:
> 
> [checks "reviewer"]
> reviewer = 1
> 
> Thanks,
> Erik
> 
> ## Testing
> - [x] Added a number of additional unit tests

Looks good, thanks for fixing! Only saw one spelling issue.

jcheck/src/test/java/org/openjdk/skara/jcheck/ReviewersCheckTests.java line 340:

> 339:     @Test
> 340:     void relazedRoleAndMissingRoleShouldFail() throws IOException {
> 341:         var commit = commit(List.of("bar", "contributor"));

Suggestion:

    void relaxedRoleAndMissingRoleShouldFail() throws IOException {

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/368