RFR: 217: Enforce check on number of required reviewers

Nir Lisker nlisker at openjdk.java.net
Tue Jan 21 11:37:12 UTC 2020

On Mon, 20 Jan 2020 15:08:03 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> One more question: If I increase the number of required reviewers to 2, does that mean both have to have the Reviewer role? If so, this won't be nearly as useful to us on the openjfx project. I suspect the same is true of many sub-projects in the JDK itself. For example, the policy in the client team is that fixes in general need 2 reviewers, at least one of which must be a "R" reviewer. OpenJFX has a similar policy (except that only "high-impact" fixes need a second reviewer) in that only one of the reviewers needs to be a "R" reviewer.
> Now that #368 has been implemented, I'll update this to support more complex reviewer requirements. Also, it makes sense not to allow relaxing the requirements below what the jcheck configuration specifies.

> `/reviewers <n> [<role>]` where `<n>` is the additional number of required reviewers.

I fear that this will be confusing. I expect that `n` is the number of reviewers, not the number of additional reviewers.


PR: https://git.openjdk.java.net/skara/pull/364

More information about the skara-dev mailing list