RFR: 217: Enforce check on number of required reviewers

Kevin Rushforth kcr at openjdk.java.net
Tue Jan 21 23:44:46 UTC 2020

On Tue, 21 Jan 2020 11:37:07 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Now that #368 has been implemented, I'll update this to support more complex reviewer requirements. Also, it makes sense not to allow relaxing the requirements below what the jcheck configuration specifies.
>> `/reviewers <n> [<role>]` where `<n>` is the additional number of required reviewers.
> I fear that this will be confusing. I expect that `n` is the number of reviewers, not the number of additional reviewers.

I agree with @nlisker. I believe that both the `jdk` and `openjfx` projects will set 1 reviewer in the .jcheck/conf file (which must be someone with a Reviewer role), with the common use case to increase that being to bump the required reviewers to 2 or maybe 3 where the additional reviewers don't have a required role. If I want to add a requirement for 2 reviewers, I would expect to be able to type:

    /reviewers 2

And the bot would figure out that it means one extra reviewer with no required role in the project. Anything else would be a "nice to have", but I wouldn't want to make it more confusing to do the simple thing.


PR: https://git.openjdk.java.net/skara/pull/364

More information about the skara-dev mailing list