RFR: 430: /summary command does not support multi-line summaries [v2]

Erik Helin ehelin at openjdk.java.net
Wed Jun 24 13:44:04 UTC 2020


On Wed, 24 Jun 2020 13:05:01 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix spelling
>>   
>>   Co-authored-by: Robin Westberg <robin at westberg.se>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/SummaryCommand.java line 64:
> 
>> 63:         } else {
>> 64:             // A single-line summary
>> 65:             var summary = args.strip();
> 
> Check if lines.size > 1 here? Perhaps that should be an error / warning?

Hm, yeah, good comment. Let me fix that!

-------------

PR: https://git.openjdk.java.net/skara/pull/678


More information about the skara-dev mailing list