RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v3]
Robin Westberg
rwestberg at openjdk.java.net
Thu Jun 25 05:56:19 UTC 2020
On Wed, 24 Jun 2020 15:07:05 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> Robin Westberg has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java
>>
>> Co-authored-by: Erik Duveblad <erik.helin at oracle.com>
>> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java
>>
>> Co-authored-by: Erik Duveblad <erik.helin at oracle.com>
>> - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java
>>
>> Co-authored-by: Erik Duveblad <erik.helin at oracle.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 245:
>
>> 244: }
>> 245: var component = next;
>> 246: next = argSplit.pollFirst();
>
> Given that you incorporated my changes to the help text I think you need to add some code here to handle the case when
> `component` is something like `"hotspot/gc"`
But it does work, there's even a test for it. :)
-------------
PR: https://git.openjdk.java.net/skara/pull/677
More information about the skara-dev
mailing list