RFR: 372: Tool support for small/minor/trivial "fast-track" changes. [v3]
Erik Helin
ehelin at openjdk.java.net
Thu Jun 25 08:36:29 UTC 2020
On Thu, 25 Jun 2020 05:54:10 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/IssueCommand.java line 245:
>>
>>> 244: }
>>> 245: var component = next;
>>> 246: next = argSplit.pollFirst();
>>
>> Given that you incorporated my changes to the help text I think you need to add some code here to handle the case when
>> `component` is something like `"hotspot/gc"`
>
> But it does work, there's even a test for it. :)
Sigh, I didn't notice the regular expression in `args.split("(?:\\s+|/)"))` Looks good then
-------------
PR: https://git.openjdk.java.net/skara/pull/677
More information about the skara-dev
mailing list