RFR: Switch to using GitLab approvals instead of award_emojis

Robin Westberg rwestberg at openjdk.java.net
Mon Nov 2 14:41:43 UTC 2020

On Mon, 2 Nov 2020 14:15:48 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> So this will remove the ability to review using emojis? This sounds like there need to be a "flag day" for switching review methods. (I'm not saying this is bad, just verifying that I understand the implications correctly.)
> Will this be a hard switch, or will you continue to also honor the "thumbs-up" emoji?

This will be a hard switch, the thumbs-up button has an unfortunate drawback, which is that GitLab does not update the merge request's "updated_at" field when it is used. This in turn means that we have had to disable several optimizations to reduce network traffic -> we have to use a much lower polling rate for GitLab -> command replies can take up to a minute instead of a few seconds.


PR: https://git.openjdk.java.net/skara/pull/937

More information about the skara-dev mailing list