RFR: Switch to using GitLab approvals instead of award_emojis

Magnus Ihse Bursie ihse at openjdk.java.net
Mon Nov 2 16:10:13 UTC 2020

On Mon, 2 Nov 2020 14:39:32 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Will this be a hard switch, or will you continue to also honor the "thumbs-up" emoji?
> This will be a hard switch, the thumbs-up button has an unfortunate drawback, which is that GitLab does not update the merge request's "updated_at" field when it is used. This in turn means that we have had to disable several optimizations to reduce network traffic -> we have to use a much lower polling rate for GitLab -> command replies can take up to a minute instead of a few seconds.

@rwestberg Sounds like an acceptable rationale for disabling the old behavior. Just make sure to communicate clearly at which point review method changes.


PR: https://git.openjdk.java.net/skara/pull/937

More information about the skara-dev mailing list