RFR: Add newline after closed issue warning
Robin Westberg
rwestberg at openjdk.java.net
Fri Nov 27 08:19:22 UTC 2020
On Thu, 26 Nov 2020 19:59:49 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> Adds a missing newline after the 'issue is not open' warning, which is currently missing, and leads to the list not being formatted correctly. See e.g. https://github.com/openjdk/jdk/pull/1444
>
> 
>
> Any testing needed for this?
Looks good, I guess a test would be nice, but since there isn't one at the moment there's no need to remedy that right now unless you really want to.
bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 487:
> 485: progressBody.append(" ⚠️ Issue is not open.\n");
> 486: }
> 487: continue;
I know I wrote this, but another solution would be to drop the `continue` here, I don't remember why it's there. :)
-------------
Marked as reviewed by rwestberg (Reviewer).
PR: https://git.openjdk.java.net/skara/pull/963
More information about the skara-dev
mailing list