RFR: Add newline after closed issue warning

Jorn Vernee jvernee at openjdk.java.net
Fri Nov 27 11:00:47 UTC 2020

On Fri, 27 Nov 2020 08:14:41 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Adds a missing newline after the 'issue is not open' warning, which is currently missing, and leads to the list not being formatted correctly. See e.g. https://github.com/openjdk/jdk/pull/1444
>> ![image](https://user-images.githubusercontent.com/5962029/100388139-12f8ff80-302a-11eb-876a-25943c7d75d8.png)
>> Any testing needed for this?
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 487:
>> 485:                                     progressBody.append(" ⚠️ Issue is not open.\n");
>> 486:                                 }
>> 487:                                 continue;
> I know I wrote this, but another solution would be to drop the `continue` here, I don't remember why it's there. :)

Ok, will do that than. (seems a little cleaner to me). I think that will only change whether the `if` below is evaluated. Maybe you wanted only one warning to be printed at a time?


PR: https://git.openjdk.java.net/skara/pull/963

More information about the skara-dev mailing list