RFR: Add newline after closed issue warning [v2]

Robin Westberg rwestberg at openjdk.java.net
Fri Nov 27 12:05:26 UTC 2020

On Fri, 27 Nov 2020 10:58:36 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 487:
>>> 485:                                     progressBody.append(" ⚠️ Issue is not open.\n");
>>> 486:                                 }
>>> 487:                                 continue;
>> I know I wrote this, but another solution would be to drop the `continue` here, I don't remember why it's there. :)
> Ok, will do that than. (seems a little cleaner to me). I think that will only change whether the `if` below is evaluated. Maybe you wanted only one warning to be printed at a time?

Yeah I guess, but then it was a bit inconsistent with the rest of the warnings anyway... So this looks good to me!


PR: https://git.openjdk.java.net/skara/pull/963

More information about the skara-dev mailing list