Integrated: forge: add HostedRepository.recentCommitComments

Erik Helin ehelin at openjdk.java.net
Wed Oct 21 07:48:20 UTC 2020


On Mon, 19 Oct 2020 13:30:42 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds the method `HostedRepository.recentCommitComments` for fetching recent commit comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it doesn't provide a `noteable_id` with the commit's hash for commit comment events. I therefore hade to make `CommitComment` support lazily fetching the hash for the commit.
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 63e61c95
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/63e61c95
Stats:     213 lines in 7 files changed: 176 ins; 20 del; 17 mod

forge: add HostedRepository.recentCommitComments

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/891


More information about the skara-dev mailing list