RFR: forge: add HostedRepository.recentCommitComments [v3]

Robin Westberg rwestberg at openjdk.java.net
Tue Oct 20 12:16:14 UTC 2020

On Mon, 19 Oct 2020 14:58:45 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> please review this patch that adds the method `HostedRepository.recentCommitComments` for fetching recent commit comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it doesn't provide a `noteable_id` with the commit's hash for commit comment events. I therefore hade to make `CommitComment` support lazily fetching the hash for the commit.
>> Thanks,
>> Erik
> Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>  - Merge master
>  - forge: add HostedRepository.recentCommitComments
>  - forge: add builder for HostUser

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/891

More information about the skara-dev mailing list