RFR: 673: PR author should be able to use /reviewers command [v2]

Robin Westberg rwestberg at openjdk.java.net
Tue Sep 15 09:04:07 UTC 2020

On Tue, 15 Sep 2020 08:49:29 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author
>> knows ahead of time that it is a complicated to PR to review).
>> Testing:
>> - [x] `make test` passes on Linux x64
>> - [x] Added one additional unit test
>> Thanks,
>> Erik
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>   PR authors should not be allowed to decrease

Looks good, but you can probably simplify it a bit since the "exclude" parameter isn't really used. :)

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersTracker.java line 105:

> 103:     }
> 104:
> 105:     static Optional<AdditionalRequiredReviewers> additionalRequiredReviewers(HostUser botUser, List<Comment>
> comments, Comment exclude) {

The exclude comment parameter probably isn't the one you are looking for, as the reply marker isn't in the command
comment but the reply.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandInvocation.java line 16:

> 14:     private final Comment comment;
> 15:
> 16:     CommandInvocation(String id, HostUser user, CommandHandler handler, String name, String args, Comment comment) {

Think you can drop this parameter if you drop the exclude param!


PR: https://git.openjdk.java.net/skara/pull/820

More information about the skara-dev mailing list