RFR: 673: PR author should be able to use /reviewers command [v2]
Erik Helin
ehelin at openjdk.java.net
Tue Sep 15 09:48:57 UTC 2020
On Tue, 15 Sep 2020 09:01:01 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> PR authors should not be allowed to decrease
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersTracker.java line 105:
>
>> 103: }
>> 104:
>> 105: static Optional<AdditionalRequiredReviewers> additionalRequiredReviewers(HostUser botUser, List<Comment>
>> comments, Comment exclude) {
>
> The exclude comment parameter probably isn't the one you are looking for, as the reply marker isn't in the command
> comment but the reply.
Thanks, fixed in 7b17768
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandInvocation.java line 16:
>
>> 14: private final Comment comment;
>> 15:
>> 16: CommandInvocation(String id, HostUser user, CommandHandler handler, String name, String args, Comment comment) {
>
> Think you can drop this parameter if you drop the exclude param!
Yep, fixed in 7b17768
-------------
PR: https://git.openjdk.java.net/skara/pull/820
More information about the skara-dev
mailing list