RFR: 694: Checking invalid email gives an exception

Robin Westberg rwestberg at openjdk.java.net
Mon Sep 21 17:04:36 UTC 2020

On Mon, 21 Sep 2020 16:14:22 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that ensures that contributors who do not have an OpenJDK username specify a valid name and
> e-mail for a pull request's `HEAD` commit.
> Testing:
> - Added a new unit test
> - `make test` passes on Linux x64
> Thanks,
> Erik

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 166:

> 164:     public void visit(AuthorNameIssue issue) {
> 165:         // We only get here for contributors without an OpenJDK username
> 166:         addFailureMessage(issue.check(), "Pull request's HEAD commit must contain a full name");

This is not strictly true, CheckRun.java around line 194 will check that all commits in a PR contain the same name and
email address. Could of course start using just the one in HEAD without that check..


PR: https://git.openjdk.java.net/skara/pull/837

More information about the skara-dev mailing list