RFR: 694: Checking invalid email gives an exception [v2]

[Erik Helin]

On Mon, 21 Sep 2020 17:02:15 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only require HEAD to have valid author
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 166:
> 
>> 164:     public void visit(AuthorNameIssue issue) {
>> 165:         // We only get here for contributors without an OpenJDK username
>> 166:         addFailureMessage(issue.check(), "Pull request's HEAD commit must contain a full name");
> 
> This is not strictly true, CheckRun.java around line 194 will check that all commits in a PR contain the same name and
> email address. Could of course start using just the one in HEAD without that check..

Thanks, updated in b49bd90

-------------

PR: https://git.openjdk.java.net/skara/pull/837