RFR: forge: add search method

Erik Helin ehelin at openjdk.java.net
Tue Sep 29 14:16:49 UTC 2020

On Tue, 29 Sep 2020 12:44:02 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> Looks good, a bit worried that auto-pagination of thousands of commits will take a while though.. :)

Since we are limiting the GitHub search to selected organizations, we should for the https://github.com/openjdk
organization get at most `O(#repos)` results (a commit can exist at most once in a repo).

> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java line 246:
>> 244:                                   .collect(Collectors.toList());
>> 245:             for (var project : projects) {
>> 246:                 var c = request.get("projects/" + project + "/repository/commits/" + hex)
> Could we use this endpoint instead? https://docs.gitlab.com/ce/api/commits.html#get-a-single-commit

That is the endpoint the code is using �� Did you perhaps miss the `+ hex` part?


PR: https://git.openjdk.java.net/skara/pull/854

More information about the skara-dev mailing list