RFR: 1236: Add jcheck option to check for large binary files [v4]

[Erik Joelsson]

On Thu, 2 Dec 2021 06:42:26 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch adds the large binary file check to the jcheck.
>> 
>> The corresponding configuration is like the following code. Each key/value in the `[checks "binary"]` is a mapper. The `key` means the file pattern and the `value` means the limited file size. For example, `.*\.bin=200B` means the file which ends with `.bin` should not exceed 200 Bytes.
>> 
>> 
>> [checks]
>> error = binary
>> 
>> [checks "binary"]
>> .*.bin=200B
>> .*.o=1k
>> 
>> 
>> The limited file size can use one of these several units:  b(Byte), kb(KiloByte), mb(MegaByte), gb(GigaByte). The units is case insensitive, which means the `Kb`, `kB` and `KB` are equals to `kb(KiloByte)`. If the unit is not provided, it defauts to `b(Byte)`. And these is no a unit called `bit`.
>> 
>> The corresponding test cases are added.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enable the binary check.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 273:

> 271:     public void visit(BinaryFileTooLargeIssue issue) {
> 272:         addFailureMessage(issue.check(), "The size of the binary file `" + issue.path() + "` is " + issue.fileSize()
> 273:                 + " Bytes, which is larger than the limited file size: "

Suggestion:

                + " Bytes, which is larger than the binary file size limit: "

cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java line 303:

> 301:         if (!ignore.contains(i.check().name())) {
> 302:             println(i, "The size of the binary file `" + i.path() + "` is " + i.fileSize()
> 303:                     + " Bytes, which is larger than the limited file size: "

Suggestion:

                    + " Bytes, which is larger than the binary file size limit: "

-------------

PR: https://git.openjdk.java.net/skara/pull/1247