RFR: 1236: Add jcheck option to check for large binary files [v4]

Guoxiong Li gli at openjdk.java.net
Fri Dec 3 13:16:30 UTC 2021


On Thu, 2 Dec 2021 14:14:06 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Enable the binary check.
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 273:
> 
>> 271:     public void visit(BinaryFileTooLargeIssue issue) {
>> 272:         addFailureMessage(issue.check(), "The size of the binary file `" + issue.path() + "` is " + issue.fileSize()
>> 273:                 + " Bytes, which is larger than the limited file size: "
> 
> Suggestion:
> 
>                 + " Bytes, which is larger than the binary file size limit: "

Fixed.

> cli/src/main/java/org/openjdk/skara/cli/JCheckCLIVisitor.java line 303:
> 
>> 301:         if (!ignore.contains(i.check().name())) {
>> 302:             println(i, "The size of the binary file `" + i.path() + "` is " + i.fileSize()
>> 303:                     + " Bytes, which is larger than the limited file size: "
> 
> Suggestion:
> 
>                     + " Bytes, which is larger than the binary file size limit: "

Fixed.

-------------

PR: https://git.openjdk.java.net/skara/pull/1247


More information about the skara-dev mailing list