RFR: 1258: Add review link/details to comments section

Guoxiong Li gli at openjdk.java.net
Fri Dec 3 17:46:52 UTC 2021

On Fri, 3 Dec 2021 17:17:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I don't like the thought of removing things from JBS. What is it you want to remove, and why? The Review link? As I argued in the bug report, I think it is useful to have and should not be removed.

I understand your meaning in the comment of [SKARA-1258](https://bugs.openjdk.java.net/browse/SKARA-1258). This patch is following your idea.

The original logic is:
1. When the user types `/issue add XXXX` at a comment of the PR, the bot will add a review link to the issue `XXXX`.
2. When the user types `/issue remove XXXX` at a comment of the PR, the bot will remove the review link which is added in the step 1. This removing step is necessary because the issue `XXXX` is not related to the PR if the user typed `/issue remove XXXX`.

The logic of this patch is:
1. Like the step 1 above. Add the review link and **a comment which makes the JBS can notify the watchers**.
2. Like the step 2 above. Remove the added link and **remove the added comment**.

The review link is added and removed as before. And this patch only cares about the comment.


PR: https://git.openjdk.java.net/skara/pull/1250

More information about the skara-dev mailing list