RFR: 1258: Add review link/details to comments section [v2]

Erik Joelsson erikj at openjdk.java.net
Tue Dec 7 14:36:17 UTC 2021

On Mon, 6 Dec 2021 16:36:19 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch adds a comment to the jira issue when the corresponding PR is submitted. Because currently, the class `Issue` has no an api to remove a comment. So I need to create and implement it, too. And the test cases are added.
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>  - Move the code about adding comment out of the reviewLink block.
>  - Not implement the unused method.

I have given this a lot of thought, and I think I'm ok with your current solution. It's a bit unfortunate to have differently formatted comments for confidential vs non confidential, but it's good enough for now.

bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 61:

> 59:     private final Logger log = Logger.getLogger("org.openjdk.skara.bots.notify");
> 60: 
> 61:     private static final String pullRequestTip = "A pull request is submitted for review.";


    private static final String pullRequestTip = "A pull request was submitted for review.";


PR: https://git.openjdk.java.net/skara/pull/1250

More information about the skara-dev mailing list