RFR: 1258: Add review link/details to comments section [v2]

Guoxiong Li gli at openjdk.java.net
Tue Dec 7 15:10:01 UTC 2021


On Tue, 7 Dec 2021 14:32:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>>
>>  - Move the code about adding comment out of the reviewLink block.
>>  - Not implement the unused method.
>
> bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 61:
>
>> 59:     private final Logger log = Logger.getLogger("org.openjdk.skara.bots.notify");
>> 60:
>> 61:     private static final String pullRequestTip = "A pull request is submitted for review.";
>
> Suggestion:
>
>     private static final String pullRequestTip = "A pull request was submitted for review.";

Fixed.

-------------

PR: https://git.openjdk.java.net/skara/pull/1250


More information about the skara-dev mailing list