RFR: 1258: Add review link/details to comments section [v2]

Guoxiong Li gli at openjdk.java.net
Thu Dec 16 08:11:53 UTC 2021

On Tue, 7 Dec 2021 14:33:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>>  - Move the code about adding comment out of the reviewLink block.
>>  - Not implement the unused method.
> I have given this a lot of thought, and I think I'm ok with your current solution. It's a bit unfortunate to have differently formatted comments for confidential vs non confidential, but it's good enough for now.

@erikj79 Thanks for your review. Could I get your help to sponsor this patch?


PR: https://git.openjdk.java.net/skara/pull/1250

More information about the skara-dev mailing list