RFR: 1293: The Skara bot should not add review links or comments to CSR issues

Guoxiong Li gli at openjdk.java.net
Wed Dec 22 14:04:32 UTC 2021


On Wed, 22 Dec 2021 13:53:03 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Hi all,
>> 
>> Currently, the review link and comment will be added to the CSR issue because the method `PullRequestWorkItem::parseIssues` get the all the issues from the PR body. This patch excludes the CSR issue and adds a corresponding test case.
>> 
>> And the method `IssueNotifier::pullRequestToTextBrief` creates the following comment body in the jira, because the method `println` prints the line seperator according to the bot server OS. But it seems that the jira can't identify this line seperator. So I adjust this method bu using the class `StringBuilder` instead of `PrintWriter`.
>> 
>> 
>> A pull request was submitted for review.
>> 
>> URL: https://git.openjdk.java.net/jfx/pull/548 Date: 2021-06-28 12:13:44 +0000
>> 
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Marked as reviewed by erikj (Lead).

@erikj79 Thanks for the review. Could I get your help to sponsor this patch?

-------------

PR: https://git.openjdk.java.net/skara/pull/1266


More information about the skara-dev mailing list