Integrated: 1293: The Skara bot should not add review links or comments to CSR issues
Guoxiong Li
gli at openjdk.java.net
Wed Dec 22 14:08:53 UTC 2021
On Wed, 22 Dec 2021 11:58:53 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> Hi all,
>
> Currently, the review link and comment will be added to the CSR issue because the method `PullRequestWorkItem::parseIssues` get the all the issues from the PR body. This patch excludes the CSR issue and adds a corresponding test case.
>
> And the method `IssueNotifier::pullRequestToTextBrief` creates the following comment body in the jira, because the method `println` prints the line seperator according to the bot server OS. But it seems that the jira can't identify this line seperator. So I adjust this method bu using the class `StringBuilder` instead of `PrintWriter`.
>
>
> A pull request was submitted for review.
>
> URL: https://git.openjdk.java.net/jfx/pull/548 Date: 2021-06-28 12:13:44 +0000
>
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong
This pull request has now been integrated.
Changeset: 56bdc6ee
Author: Guoxiong Li <gli at openjdk.org>
Committer: Erik Joelsson <erikj at openjdk.org>
URL: https://git.openjdk.java.net/skara/commit/56bdc6eefd2ce9be686efa7b231611a83503032e
Stats: 70 lines in 3 files changed: 62 ins; 1 del; 7 mod
1293: The Skara bot should not add review links or comments to CSR issues
Reviewed-by: erikj
-------------
PR: https://git.openjdk.java.net/skara/pull/1266
More information about the skara-dev
mailing list