[skara] RFR: pr: only act on commit comments on known branches

Robin Westberg rwestberg at openjdk.java.net
Wed Feb 24 15:35:48 UTC 2021


On Wed, 24 Feb 2021 14:48:37 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes the `CommitCommentsWorkItem` filter out commit comments that aren't made on commits on a known branch in the remote repository. Some forges can return comments on commits in pull requests, which aren't comments we want to act upon (commit commands are only for integrated commits on a known branch).
> 
> Testing:
> - [x] Added a unit test
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

Marked as reviewed by rwestberg (Reviewer).

-------------

PR: https://git.openjdk.java.net/skara/pull/1034


More information about the skara-dev mailing list