RFR: Read resolvedInBuild JBS property properly

Erik Helin ehelin at openjdk.java.net
Wed Mar 10 09:40:56 UTC 2021


On Mon, 1 Mar 2021 14:23:30 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> The resolvedInBuild property was not read correctly from JBS, leading to incorrect issue labels.

Looks good, I just have a minor comment inline!

jbs/src/main/java/org/openjdk/skara/jbs/Backports.java line 77:

> 75:         }
> 76:         if (issue.properties().containsKey("customfield_10006")) {
> 77:             return JdkVersion.parse(versionString.get(0), issue.properties().get("customfield_10006").asString());

Would you mind creating a variable naming the custom field? For example:

var resolvedInBuild = "customfield_10006";
if (issue.properties().containsKey(resolvedInBuild)) {

-------------

PR: https://git.openjdk.java.net/skara/pull/1042


More information about the skara-dev mailing list