RFR: Read resolvedInBuild JBS property properly
Robin Westberg
rwestberg at openjdk.java.net
Wed Mar 10 10:35:39 UTC 2021
On Wed, 10 Mar 2021 09:38:12 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> The resolvedInBuild property was not read correctly from JBS, leading to incorrect issue labels.
>
> jbs/src/main/java/org/openjdk/skara/jbs/Backports.java line 77:
>
>> 75: }
>> 76: if (issue.properties().containsKey("customfield_10006")) {
>> 77: return JdkVersion.parse(versionString.get(0), issue.properties().get("customfield_10006").asString());
>
> Would you mind creating a variable naming the custom field? For example:
>
> var resolvedInBuild = "customfield_10006";
> if (issue.properties().containsKey(resolvedInBuild)) {
This exist in quite a few places already, and properly fixing it would require a larger refactoring. So I think we should do that separately.
-------------
PR: https://git.openjdk.java.net/skara/pull/1042
More information about the skara-dev
mailing list