RFR: Read resolvedInBuild JBS property properly

Erik Helin ehelin at openjdk.java.net
Wed Mar 10 14:08:56 UTC 2021


On Wed, 10 Mar 2021 10:33:25 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> jbs/src/main/java/org/openjdk/skara/jbs/Backports.java line 77:
>> 
>>> 75:         }
>>> 76:         if (issue.properties().containsKey("customfield_10006")) {
>>> 77:             return JdkVersion.parse(versionString.get(0), issue.properties().get("customfield_10006").asString());
>> 
>> Would you mind creating a variable naming the custom field? For example:
>> 
>> var resolvedInBuild = "customfield_10006";
>> if (issue.properties().containsKey(resolvedInBuild)) {
>
> This exist in quite a few places already, and properly fixing it would require a larger refactoring. So I think we should do that separately.

Ok, sounds good!

-------------

PR: https://git.openjdk.java.net/skara/pull/1042


More information about the skara-dev mailing list