RFR: 1071: auto-set `/csr` flag from JBS state [v4]

Erik Joelsson erikj at openjdk.java.net
Mon Nov 29 15:09:00 UTC 2021

On Sat, 27 Nov 2021 14:16:24 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> Currently, the author of the PR or a reviewer could type `/csr` in the comment to direct the need of the CSR.
>> It is good for the bot to automatically scan the `scr for` link and set the `csr` label for the PR.
>> This patch adds the automatically scanning feature. And the corresponding tests are added.
>> Thanks for taking the time to review.
>> Best Regards,
>> -- Guoxiong
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Avoid the bot adding the CSR label again.

bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java line 131:

> 129:                             // a Reviewer had requested and integrate it without satisfying that requirement.
> 130:                             log.info("CSR closed and withdrawn for " + describe(pr) + ", not removing CSR label");
> 131:                         } else if (!pr.labelNames().contains(CSR_LABEL)) {

I'm not sure about this case. For this to realistically happen, a CSR would have been filed and withdrawn before the PR was created. I don't think we should automatically add the label in this situation. @kevinrushforth what do you think?

If the label is already there, then we should certainly leave it there however.


PR: https://git.openjdk.java.net/skara/pull/1245

More information about the skara-dev mailing list