RFR: 1071: auto-set `/csr` flag from JBS state [v4]

Kevin Rushforth kcr at openjdk.java.net
Mon Nov 29 15:15:27 UTC 2021

On Mon, 29 Nov 2021 15:06:16 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>   Avoid the bot adding the CSR label again.
> bots/csr/src/main/java/org/openjdk/skara/bots/csr/CSRBot.java line 131:
>> 129:                             // a Reviewer had requested and integrate it without satisfying that requirement.
>> 130:                             log.info("CSR closed and withdrawn for " + describe(pr) + ", not removing CSR label");
>> 131:                         } else if (!pr.labelNames().contains(CSR_LABEL)) {
> I'm not sure about this case. For this to realistically happen, a CSR would have been filed and withdrawn before the PR was created. I don't think we should automatically add the label in this situation. @kevinrushforth what do you think?
> If the label is already there, then we should certainly leave it there however.

I agree that we need not (should not) add a label in this case. I also agree that if there is a label we must leave it.

This will handle the case where a PR author thinks a CSR might be needed, creates a CSR, withdraws it, creates the PR, and then later a Reviewer indicates that a CSR is needed. In that case, the bot should add the label and not auto-remove it.


PR: https://git.openjdk.java.net/skara/pull/1245

More information about the skara-dev mailing list