RFR: 1236: Add jcheck option to check for large binary files

[Kevin Rushforth]

On Tue, 30 Nov 2021 11:42:56 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch adds the large binary file check to the jcheck.
> 
> The corresponding configuration is like the following code. Each key/value in the `[checks "binary"]` is a mapper. The `key` means the file pattern and the `value` means the limited file size. For example, `.*\.bin=1b` means the file which ends with `.bin` should not exceed 200 Bytes.
> 
> 
> [checks]
> error = binary
> 
> [checks "binary"]
> .*.bin=200B
> .*.o=1k
> 
> 
> The limited file size can use one of these several units:  b(Byte), kb(KiloByte), mb(MegaByte), gb(GigaByte). The units is case insensitive, which means the `Kb`, `kB` and `KB` are equals to `kb(KiloByte)`. If the unit is not provided, it defauts to `b(Byte)`. And these is no a unit called `bit`.
> 
> The corresponding test cases are added.
> 
> Best Regards,
> -- Guoxiong

I would rather see two separate parameters, a size and a list of files (with regex support, like we have for the whitespace check), so that we don't have to repeat the size. We don't need the flexibility to set the limit per-extension.

-------------

PR: https://git.openjdk.java.net/skara/pull/1247