RFR: 1236: Add jcheck option to check for large binary files

Guoxiong Li gli at openjdk.java.net
Tue Nov 30 11:46:37 UTC 2021

Hi all,

This patch adds the large binary file check to the jcheck.

The corresponding configuration is like the following code. Each key/value in the `[checks "binary"]` is a mapper. The `key` means the file pattern and the `value` means the limited file size. For example, `.*\.bin=1b` means the file which ends with `.bin` should not exceed 200 Bytes.

error = binary

[checks "binary"]

The limited file size can use one of these several units:  b(Byte), kb(KiloByte), mb(MegaByte), gb(GigaByte). The units is case insensitive, which means the `Kb`, `kB` and `KB` are equals to `kb(KiloByte)`. If the unit is not provided, it defauts to `b(Byte)`. And these is no a unit called `bit`.

The corresponding test cases are added.

Best Regards,
-- Guoxiong


Commit messages:
 - Cann't assert the file size directly.
 - Fix NPE.
 - 1236: Add jcheck option to check for large binary files

Changes: https://git.openjdk.java.net/skara/pull/1247/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1247&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-1236
  Stats: 420 lines in 13 files changed: 338 ins; 44 del; 38 mod
  Patch: https://git.openjdk.java.net/skara/pull/1247.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1247/head:pull/1247

PR: https://git.openjdk.java.net/skara/pull/1247

More information about the skara-dev mailing list