RFR: 1254: Add a checkbox for CSR requirement

Erik Joelsson erikj at openjdk.java.net
Tue Nov 30 22:06:50 UTC 2021

On Tue, 30 Nov 2021 17:12:26 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> I needed to think about this for a bit, but I think you are right. 
>> I was instinctively trying to keep the PR bot from having to query JBS for CSR status, because we currently have a label which made checking the CSR state very cheap and obvious. But on the other hand, we are fetching the issue from JBS anyway during every CheckRun, so adding this extra step isn't that expensive.
> @erikj79 I re-think about this. Even though we decide to use the new logic and add the new label `csr-approved` at the end,  we shouldn't implement the feature at this patch. Because the goal of this patch is only to add a checkbox for CSR requirement.
> So I advice to file a new issue to continue the discussion. The new issue title can be `Investigating to add a label 'csr-approved' to mark the CSR is approved`.
> Back to this patch, I think it is good to use the old logic to implement the enhancement so that the users (OpenJDK developers) can take advantage of this patch as soon as possible.

I don't think we need a new label. Your suggestion to tell state 1 and 3 apart by checking if a CSR issue exists seems good enough to me.


PR: https://git.openjdk.java.net/skara/pull/1246

More information about the skara-dev mailing list