RFR: 1184: Failure to retrieve the JBS bug should be an integration blocker

Erik Joelsson erikj at openjdk.java.net
Mon Oct 18 18:42:19 UTC 2021

On Mon, 18 Oct 2021 18:37:39 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch makes it an integration blocker if the Skara bot is unable to read an Issue in the issue tracker system that the PR is claiming to fix. The PR bot for github repos uses credentials that can only see publicly viewable bugs, so this will make it impossible for Oracle employees to accidentally use a "confidential" bug for change in OpenJDK.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 505:

> 503:                     }
> 504:                 }
> 505:                 progressBody.append("\n");

One of the logical paths here was missing adding the newline, while I definitely think it should do so, so I figured it should be moved to the end instead.

bots/pr/src/test/java/org/openjdk/skara/bots/pr/IssueTests.java line 189:

> 187:             var editHash = CheckableRepository.appendAndCommit(localRepo);
> 188:             localRepo.push(editHash, author.url(), "edit", true);
> 189:             var issue1 = credentials.createIssue(issues, "Main");

This test needed a bit of a rewrite so that all issues referenced were actually present in the mock issue tracker.


PR: https://git.openjdk.java.net/skara/pull/1236

More information about the skara-dev mailing list