RFR: 1184: Failure to retrieve the JBS bug should be an integration blocker

[Erik Joelsson]

On Mon, 18 Oct 2021 18:37:39 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch makes it an integration blocker if the Skara bot is unable to read an Issue in the issue tracker system that the PR is claiming to fix. The PR bot for github repos uses credentials that can only see publicly viewable bugs, so this will make it impossible for Oracle employees to accidentally use a "confidential" bug for change in OpenJDK.

Here is a PR in the playground where the new functionality can be observed: https://github.com/openjdk/playground/pull/91

It's unfortunate that the error message appears twice in the PR body, but I can't really see a good way out of that. The check itself fits best in the integration blocker group of checks, which are calculated in the bot itself, separate from Jcheck. The "Issue(s)" section is meant to be informative and is generated separately. When generating the Issue(s) section, it will also try to contact the issue tracker to get issue data, and if that fails (which it could do on its own, independent of the integration blocker check) I think it would be wrong it just silently ignore that. The goal is to make this obvious to the user, so I don't think it's a big problem.

-------------

PR: https://git.openjdk.java.net/skara/pull/1236