Contributions on GitHub getting stuck

Dalibor Topic dalibor.topic at
Fri Oct 22 13:13:32 UTC 2021

On 22.10.2021 01:19, Magnus Ihse Bursie wrote:
> At the very least I think Skara should add some message in these cases 
> saying explicitly "You need a JBS issue too get this PR reviewed. Please 
> ask on the relevant mailing list for sponsorship". And maybe we should 
> rethink if we perhaps should not send a mail in any case, at least 
> notifying folks that there is an incoming PR that might need guidance.

The status of an issue implies that you need a JBS issue implicitly:

See e.g.

* Change must not contain extraneous whitespace (check)
* Commit message must refer to an issue (no check) <----- here ;)
* Change must be properly reviewed (no check)

I took a brief look at

Most of them are from people in the OpenJDK census who have contributed 
to the jdk repo before, so filing an issue should not be a problem in 
their case, if they so desire, in order to move their PR forward.

The others have not contributed to the jdk repo yet, so in their case, a 
more explicit nudge towards asking on the list may be useful, but if a 
bot were to do the nudging, then it should really take the census into 
account - I'm not sure regular contributors would appreciate being 
regularly e-mailed by a bot that they didn't file an issue for their PR yet.

In those cases, we should assume that the contributor know best what 
they are doing, and will file for an issue when they are ready.

dalibor topic
<> Dalibor Topic
Consulting Product Manager
Phone: +494089091214 <tel:+494089091214>, Mobile: +491737185961
<tel:+491737185961>, Video: dalibor.topic at
<sip:dalibor.topic at>

Oracle Global Services Germany GmbH
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRB 246209
Geschäftsführer: Ralf Herrmann

More information about the skara-dev mailing list