Contributions on GitHub getting stuck

[Magnus Ihse Bursie]

On 2021-10-22 15:13, Dalibor Topic wrote:
> On 22.10.2021 01:19, Magnus Ihse Bursie wrote:
>> At the very least I think Skara should add some message in these 
>> cases saying explicitly "You need a JBS issue too get this PR 
>> reviewed. Please ask on the relevant mailing list for sponsorship". 
>> And maybe we should rethink if we perhaps should not send a mail in 
>> any case, at least notifying folks that there is an incoming PR that 
>> might need guidance.
>
> The status of an issue implies that you need a JBS issue implicitly:
>
> See e.g. https://github.com/openjdk/jdk/pull/6076
>
> Progress
> * Change must not contain extraneous whitespace (check)
> * Commit message must refer to an issue (no check) <----- here ;)
> * Change must be properly reviewed (no check)
>
> I took a brief look at 
> https://github.com/openjdk/jdk/pulls?q=is%3Apr+is%3Aopen+-is%3Adraft+-label%3Arfr+-label%3Aoca+
>
> Most of them are from people in the OpenJDK census who have 
> contributed to the jdk repo before, so filing an issue should not be a 
> problem in their case, if they so desire, in order to move their PR 
> forward.
>
> The others have not contributed to the jdk repo yet, so in their case, 
> a more explicit nudge towards asking on the list may be useful, but if 
> a bot were to do the nudging, then it should really take the census 
> into account - I'm not sure regular contributors would appreciate 
> being regularly e-mailed by a bot that they didn't file an issue for 
> their PR yet.
>
> In those cases, we should assume that the contributor know best what 
> they are doing, and will file for an issue when they are ready.

I agree. People who already have an OpenJDK id and can file bugs 
presumably know what needs to be done.

So this boils down to that I think a bot should notify new contributors 
that posts a PR which does not have a bug ID, giving them a pointer on 
how to proceed.

/Magnus

>
> cheers,
> dalibor topic