RFR: 1170: Notify bot reposts commit comments if another notifier fails

Kevin Rushforth kcr at openjdk.java.net
Mon Sep 13 15:51:52 UTC 2021


On Mon, 13 Sep 2021 15:39:11 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Prevent the CommitCommentNotifier from posting the exact same comment twice.

Looks good.

bots/notify/src/test/java/org/openjdk/skara/bots/notify/comment/CommitCommentNotifierTests.java line 175:

> 173:     void testNoRepeatedCommitComment(TestInfo testInfo) throws IOException {
> 174:         try (var credentials = new HostCredentials(testInfo);
> 175:              var tempFolder = new TemporaryDirectory()) {

Minor: indentation is different from below lines.

-------------

Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1218


More information about the skara-dev mailing list