RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v5]

Erik Joelsson erikj at openjdk.java.net
Fri Apr 15 12:48:36 UTC 2022

On Fri, 15 Apr 2022 06:45:37 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> I pondered on this some more and I think we can fix it. We can extend `CommandHandler::handle` for PRs with another parameter for returning a collection of labels to add to the PR. PullRequestCommandWorkItem calls this with an empty collection and any command that needs to add labels after the reply is posted can add them to this collection.
> Good idea. Actually, we also need to remove labels sometimes, such as the command `/jep unneeded`. What about returning a pair collections like `<labelsToAdd, labelsToRemove>` ?

At least in the jep command case, removing before posting comment is fine. I don't think we should add a dead parameter at this time. This can easily be extended if we ever find a need for it.


PR: https://git.openjdk.java.net/skara/pull/1297

More information about the skara-dev mailing list