RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v5]

Erik Joelsson erikj at openjdk.java.net
Fri Apr 15 12:54:42 UTC 2022


On Fri, 15 Apr 2022 12:45:40 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Good idea. Actually, we also need to remove labels sometimes, such as the command `/jep unneeded`. What about returning a pair collections like `<labelsToAdd, labelsToRemove>` ?
>
> At least in the jep command case, removing before posting comment is fine. I don't think we should add a dead parameter at this time. This can easily be extended if we ever find a need for it.

Hm, at second thought, I take that back. Removing it after adding a new comment is better.

-------------

PR: https://git.openjdk.java.net/skara/pull/1297


More information about the skara-dev mailing list