RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v5]
Guoxiong Li
gli at openjdk.java.net
Mon Apr 18 09:23:22 UTC 2022
On Fri, 15 Apr 2022 12:51:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> At least in the jep command case, removing before posting comment is fine. I don't think we should add a dead parameter at this time. This can easily be extended if we ever find a need for it.
>
> Hm, at second thought, I take that back. Removing it after adding a new comment is better.
I updated the code just now. The new code changes the PR labels after commenting just as we discussed before.
And I refactored the method `processCommand` to avoid the multi-level nested conditional statements.
-------------
PR: https://git.openjdk.java.net/skara/pull/1297
More information about the skara-dev
mailing list