RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v12]

Erik Joelsson erikj at openjdk.java.net
Thu Apr 21 17:23:09 UTC 2022


On Wed, 20 Apr 2022 22:12:07 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch implements the features about the `/jep` command and JEP bot. The detailed designs and discussions are listed at [1][2].
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>> 
>> [1] https://mail.openjdk.java.net/pipermail/skara-dev/2021-December/005481.html
>> [2] https://mail.openjdk.java.net/pipermail/skara-dev/2022-March/005770.html
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use static import.

bots/jep/src/main/java/org/openjdk/skara/bots/jep/JEPBot.java line 74:

> 72:             if (jepComment == null) {
> 73:                 if (pr.labelNames().contains(JEP_LABEL)) {
> 74:                     pr.removeLabel(JEP_LABEL);

Missed this remove label in the previous review due to the long thread in the middle of the block. Please add logging here too.

-------------

PR: https://git.openjdk.java.net/skara/pull/1297


More information about the skara-dev mailing list