RFR: SKARA-1096: New command and label for JEPs, similar to CSR [v12]

Guoxiong Li gli at openjdk.java.net
Thu Apr 21 17:56:34 UTC 2022

On Thu, 21 Apr 2022 17:14:28 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>>   Use static import.
> bots/jep/src/main/java/org/openjdk/skara/bots/jep/JEPBot.java line 74:
>> 72:             if (jepComment == null) {
>> 73:                 if (pr.labelNames().contains(JEP_LABEL)) {
>> 74:                     pr.removeLabel(JEP_LABEL);
> Missed this remove label in the previous review due to the long thread in the middle of the block. Please add logging here too.

I missed it, too. Added. Use the `info` level instead of `fine` because the condition only occurs when the developers add the `jep` label manually in the PR.


PR: https://git.openjdk.java.net/skara/pull/1297

More information about the skara-dev mailing list