RFR: 1560: Backport command fails to load census [v2]
Erik Joelsson
erikj at openjdk.org
Wed Aug 24 23:26:19 UTC 2022
On Wed, 24 Aug 2022 22:52:17 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added comment
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CensusInstance.java line 165:
>
>> 163: }
>> 164:
>> 165: class LimitedCensusInstance {
>
> Maybe move this to its own file? I try to avoid having more than one top level class in the same file, but do whatever makes the most sense (maybe Skara uses this in other places?).
I will think about it. This is a rather common pattern in Skara, which is why I went for it.
-------------
PR: https://git.openjdk.org/skara/pull/1362
More information about the skara-dev
mailing list