RFR: 1560: Backport command fails to load census [v2]

Kevin Rushforth kcr at openjdk.org
Wed Aug 24 22:56:32 UTC 2022

On Wed, 24 Aug 2022 21:48:38 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> This patch attempts to fix the problem where a commit command (in our case a /backport command) fails to instantiate a CensusInstance, due to the configured jcheck "project", at the particular commit, not existing in the census in question. What happens then is that CensusInstance.create fails, which triggers an endless series of retries in the bot.
>> Since none of the current commit commands have a need for the "project" part of the census, I decided to create a separate CensusInstance type `LimitedCensusInstance` without the "project", and explicitly use this in the commit commands.
>> Tests are passing, and I could manually verify that this solves the problem we currently have with a bad /backport command in a private GitLab instance.
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>   Added comment

Looks good.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CensusInstance.java line 165:

> 163: }
> 164: 
> 165: class LimitedCensusInstance {

Maybe move this to its own file? I try to avoid having more than one top level class in the same file, but do whatever makes the most sense (maybe Skara uses this in other places?).


Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.org/skara/pull/1362

More information about the skara-dev mailing list