Integrated: 1560: Backport command fails to load census
Erik Joelsson
erikj at openjdk.org
Thu Aug 25 17:45:49 UTC 2022
On Wed, 24 Aug 2022 21:25:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> This patch attempts to fix the problem where a commit command (in our case a /backport command) fails to instantiate a CensusInstance, due to the configured jcheck "project", at the particular commit, not existing in the census in question. What happens then is that CensusInstance.create fails, which triggers an endless series of retries in the bot.
>
> Since none of the current commit commands have a need for the "project" part of the census, I decided to create a separate CensusInstance type `LimitedCensusInstance` without the "project", and explicitly use this in the commit commands.
>
> Tests are passing, and I could manually verify that this solves the problem we currently have with a bad /backport command in a private GitLab instance.
This pull request has now been integrated.
Changeset: c7fc108a
Author: Erik Joelsson <erikj at openjdk.org>
URL: https://git.openjdk.org/skara/commit/c7fc108a271580fa7e6afecf290d5ba0fafeba05
Stats: 194 lines in 9 files changed: 113 ins; 64 del; 17 mod
1560: Backport command fails to load census
Reviewed-by: kcr, gli
-------------
PR: https://git.openjdk.org/skara/pull/1362
More information about the skara-dev
mailing list