RFR: 1555: Remove support for review by award emojis in GitLab

Erik Joelsson erikj at openjdk.org
Thu Aug 25 18:50:05 UTC 2022

This patch removes support for using award emojis for marking an MR in GitLab as reviewed. This was the original Skara implementation from back when GitLab did not have an `approve` button. In https://github.com/openjdk/skara/pull/939, support for the new approve button was introduced and the award emojis were deprecated. I think it's now time to remove them completely.

The removed test had an assumeTrue that made it never run, as the TestForge had support for review body, so I chose to remove the whole test.


Commit messages:
 - SKARA-1555

Changes: https://git.openjdk.org/skara/pull/1363/files
 Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1363&range=00
  Issue: https://bugs.openjdk.org/browse/SKARA-1555
  Stats: 219 lines in 10 files changed: 0 ins; 214 del; 5 mod
  Patch: https://git.openjdk.org/skara/pull/1363.diff
  Fetch: git fetch https://git.openjdk.org/skara pull/1363/head:pull/1363

PR: https://git.openjdk.org/skara/pull/1363

More information about the skara-dev mailing list