RFR: 1690: Make jcheck cli able to use conf from workspace or other commit [v3]

Zhao Song zsong at openjdk.org
Thu Dec 1 00:20:56 UTC 2022

On Wed, 30 Nov 2022 23:29:41 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>>   implemented case 5
> vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java line 1687:
>> 1685:     @Override
>> 1686:     public Commit staged() throws IOException {
>> 1687:         var author = new Author("jcheck", "jcheck at none.none");
> For the default user and email, there is already a `::userName` method. You can create one for email as well, and then use these values as fallbacks (`Optional.orElse`).

> There are a lot of minor things, but all in all this turned out better than I had imagined. Looking forward to using it.
> Have you tried all the options against a repository with various degrees of local changes in it?

Yes,  I tried all the options and all the combination of options.


PR: https://git.openjdk.org/skara/pull/1428

More information about the skara-dev mailing list